Skip to content

MINOR: reuse toConfigObject(Map) to generate Config#8889

Merged
rhauch merged 1 commit into
apache:trunkfrom
chia7712:KAFKA-REFACTOR-MockAdminClient-getResourceDescription
Jun 17, 2020
Merged

MINOR: reuse toConfigObject(Map) to generate Config#8889
rhauch merged 1 commit into
apache:trunkfrom
chia7712:KAFKA-REFACTOR-MockAdminClient-getResourceDescription

Conversation

@chia7712

Copy link
Copy Markdown
Member

from #8853 (comment)

nit: I think that we can use toConfigObject(topicMetadata.configs) here.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@rhauch rhauch left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @chia7712. I can merge this once we get a green build.

@rhauch

rhauch commented Jun 17, 2020

Copy link
Copy Markdown
Contributor

one green build, two red builds with failures on flaky tests not affected by this very minor change.

@rhauch
rhauch merged commit 3b7c2ab into apache:trunk Jun 17, 2020
rhauch pushed a commit that referenced this pull request Jun 17, 2020
Author: Chia-Ping Tsai <chia7712@gmail.com>
Reviewers: Randall Hauch <rhauch@gmail.com>, David Jacot <david.jacot@gmail.com>
Kvicii pushed a commit to Kvicii/kafka that referenced this pull request Jun 21, 2020
* 'trunk' of github.com:apache/kafka:
  KAFKA-10168: fix StreamsConfig parameter name variable (apache#8865)
  MINOR: code cleanup for inconsistent naming (apache#8871)
  KAFKA-10138: Prefer --bootstrap-server for reassign_partitions command in ducktape tests (apache#8898)
  KAFKA-10185: Restoration info logging (apache#8896)
  KAFKA-9891: add integration tests for EOS and StandbyTask (apache#8890)
  MINOR: Reduce build time by gating test coverage plugins behind a flag (apache#8899)
  KAFKA-10141; Add more detail to log segment delete messages (apache#8850)
  KAFKA-10113; Specify fetch offsets correctly in `LogTruncationException` (apache#8822)
  KAFKA-10167: use the admin client to read end-offset (apache#8876)
  MINOR: Upgrade ducktape to 0.7.8 (apache#8879)
  KAFKA-10123; Fix incorrect value for AWAIT_RESET#hasPosition (apache#8841)
  KAFKA-9896: fix flaky StandbyTaskEOSIntegrationTest (apache#8883)
  MINOR: clean up unused checkstyle suppressions for Streams (apache#8861)
  MINOR: reuse toConfigObject(Map) to generate Config (apache#8889)
  MINOR: Upgrade jetty to 9.4.27.v20200227 and jersey to 2.31 (apache#8859)
  MINOR: Fix flaky HighAvailabilityTaskAssignorIntegrationTest (apache#8884)
  KAFKA-10147 MockAdminClient#describeConfigs(Collection<ConfigResource>) is unable to handle broker resource (apache#8853)
  KAFKA-10165: Remove Percentiles from e2e metrics (apache#8882)

# Conflicts:
#	core/src/main/scala/kafka/log/Log.scala
@chia7712
chia7712 deleted the KAFKA-REFACTOR-MockAdminClient-getResourceDescription branch March 25, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants